DPL: modernize workflow construction code using ranges by aalkin · Pull Request #14907 · AliceO2Group/AliceO2

aalkin · 2025-12-10T09:46:33Z

Replace for loops with ranges manipulation where appropriate in workflow construction code

github-actions · 2025-12-10T09:52:15Z

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

alibuild · 2025-12-10T14:13:52Z

Error while checking build/O2/fullCI_slc9 for a68da09 at 2025-12-13 00:07:

## sw/BUILD/O2-full-system-test-latest/log
command o2-sim-digitizer-workflow -n 5 --simPrefixQED qed/o2sim --qed-x-section-ratio 4477.35 --disable-mc --sims o2sim --tpc-lanes 32 --shm-segment-size 8000000000 -b --skipDet TRD --configKeyValues "HBFUtils.nHBFPerTF=128;HBFUtils.orbitFirst=0;HBFUtils.orbitFirstSampled=0;HBFUtils.obligatorySOR=false;HBFUtils.runNumber=310000;;HBFUtils.maxNOrbits=128;" --interactionRate 50000 --early-forward-policy always had nonzero exit code 128
[ERROR] Workflow crashed - PID 3294 (PHOSDigitizer) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3265 (MIDDigitizer) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3149 (ZDCDigitizer) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3207 (ITSDigitizer) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3178 (CPVDigitizer) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3555 (TPCDigitizer_18) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3410 (TPCDigitizer_13) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 4106 (TPCDigitizer_9) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3236 (MFTDigitizer) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 4048 (TPCDigitizer_7) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3381 (TPCDigitizer_12) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3729 (TPCDigitizer_24) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3526 (TPCDigitizer_17) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3758 (TPCDigitizer_25) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 2975 (TPCDigitizer_0) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3700 (TPCDigitizer_23) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3439 (TPCDigitizer_14) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3497 (TPCDigitizer_16) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3845 (TPCDigitizer_28) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 4019 (TPCDigitizer_6) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3004 (TPCDigitizer_1) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3990 (TPCDigitizer_5) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 4077 (TPCDigitizer_8) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3874 (TPCDigitizer_29) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3352 (TPCDigitizer_11) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3323 (TPCDigitizer_10) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3584 (TPCDigitizer_19) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3613 (TPCDigitizer_20) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3062 (TPCDigitizer_3) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3642 (TPCDigitizer_21) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3033 (TPCDigitizer_2) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3816 (TPCDigitizer_27) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3903 (TPCDigitizer_30) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3932 (TPCDigitizer_31) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3961 (TPCDigitizer_4) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3468 (TPCDigitizer_15) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3787 (TPCDigitizer_26) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3671 (TPCDigitizer_22) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR]  - Device TPCDigitizer_0: pid 2975 (exit 128)
[ERROR]  - Device TPCDigitizer_1: pid 3004 (exit 128)
[ERROR]  - Device TPCDigitizer_2: pid 3033 (exit 128)
[ERROR]  - Device TPCDigitizer_3: pid 3062 (exit 128)
[ERROR]  - Device ZDCDigitizer: pid 3149 (exit 128)
[ERROR]  - Device CPVDigitizer: pid 3178 (exit 128)
[ERROR]  - Device ITSDigitizer: pid 3207 (exit 128)
[ERROR]  - Device MFTDigitizer: pid 3236 (exit 128)
[ERROR]  - Device MIDDigitizer: pid 3265 (exit 128)
[0 more errors; see full log]

Full log here.

alibuild · 2025-12-13T07:08:32Z

Error while checking build/O2/fullCI_slc9 for 9394914 at 2025-12-13 08:08:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/14907-slc9_x86-64/0/Framework/Core/src/AnalysisSupportHelpers.cxx:131:42: error: 'struct o2::framework::DataProcessorSpec' has no member named 'outpus'; did you mean 'outputs'?
ninja: build stopped: subcommand failed.

Full log here.

ktf · 2025-12-16T21:03:55Z

Works on hyperloop, fullCI is also ok, halves the affected code. Merging.

aalkin added 14 commits December 10, 2025 10:44

remove obsolete code

113d551

std::any_of instead of a loop

f52b13d

std::find_if instead of a loop

cfe60b9

use range adaptors for spawnerInputs

c2798e9

update addMissingOutputsToReader with ranges

3aec9e4

update addMissingOutputsToSpawner with ranges

e97ad87

update addMissingOutputsToBuilder with ranges

80deb08

update addMissingOutputsToAnalysisCCDBFetcher with ranges

95ad8da

remove unused includes

a098c0c

remove unused includes

6c1c30f

use ranges to populate requestedIDXs in adjustTopology

c875b91

use ranges to populate requestedDYNs and spawnerInputs in adjustTopology

adf24a1

use ranges to populate requestedAODs in adjustTopology

072ccf1

ensure constness

b9f6aac

aalkin requested a review from a team as a code owner December 10, 2025 09:46

Please consider the following formatting changes

da95b4c

alibuild mentioned this pull request Dec 10, 2025

Please consider the following formatting changes to #14907 aalkin/AliceO2#117

Merged

Merge pull request #117 from alibuild/alibot-cleanup-14907

cbc4b65

aalkin and others added 2 commits December 10, 2025 11:31

extract filters/transformations into helpers; merge identical functions

e881667

Please consider the following formatting changes

646c8e2

alibuild mentioned this pull request Dec 10, 2025

Please consider the following formatting changes to #14907 aalkin/AliceO2#118

Merged

aalkin added 2 commits December 10, 2025 11:35

Merge pull request #118 from alibuild/alibot-cleanup-14907

7d8e3a6

fix

a68da09

aalkin added 2 commits December 12, 2025 23:40

potential fix for ccdb-fetcher issue

2c49488

fixup! potential fix for ccdb-fetcher issue

9394914

alibuild mentioned this pull request Dec 12, 2025

Please consider the following formatting changes to #14907 aalkin/AliceO2#120

Merged

aalkin marked this pull request as draft December 13, 2025 07:36

aalkin added 2 commits December 13, 2025 08:55

fixup! potential fix for ccdb-fetcher issue

ac02539

fix

a484194

aalkin marked this pull request as ready for review December 13, 2025 12:24

alibuild and others added 2 commits December 13, 2025 12:25

Please consider the following formatting changes

8879b6f

Merge pull request #120 from alibuild/alibot-cleanup-14907

20415ab

aalkin requested a review from ktf December 13, 2025 17:00

ktf merged commit 70b1040 into AliceO2Group:dev Dec 16, 2025
11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DPL: modernize workflow construction code using ranges#14907

DPL: modernize workflow construction code using ranges#14907
ktf merged 26 commits intoAliceO2Group:devfrom
aalkin:ranges-modernize-workflow-construction

aalkin commented Dec 10, 2025

Uh oh!

github-actions bot commented Dec 10, 2025

Uh oh!

alibuild commented Dec 10, 2025 •

edited

Loading

Uh oh!

alibuild commented Dec 13, 2025

Uh oh!

Uh oh!

ktf commented Dec 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Conversation

aalkin commented Dec 10, 2025

Uh oh!

github-actions bot commented Dec 10, 2025

Uh oh!

alibuild commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Dec 13, 2025

Uh oh!

Uh oh!

ktf commented Dec 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

alibuild commented Dec 10, 2025 •

edited

Loading